Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the output of the GET /activity to just contain the array of ws ids #12271

Merged

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Dec 23, 2018

What does this PR do?

The new GET /activity REST endpoint introduced by #12177 returns the full serialized page object as its output instead of just the array of workspace ids as it was meant to return.

This PR fixes that and also adds a test for it.

What issues does this PR reference?

#12091

not the full page object.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@metlos metlos added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/platform labels Dec 23, 2018
@metlos metlos requested a review from mshaposhnik as a code owner December 23, 2018 00:48
@metlos
Copy link
Contributor Author

metlos commented Dec 23, 2018

ci-test

@che-bot
Copy link
Contributor

che-bot commented Dec 23, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12271
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Dec 23, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12271
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk skabashnyuk merged commit 80596fb into eclipse-che:master Dec 24, 2018
@benoitf benoitf added this to the 6.16.0 milestone Dec 24, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 24, 2018
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metlos metlos deleted the fix-workspace-activity-output branch December 30, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants